Skip to content

[DO NOT MERGE] - Testing #467 on oasis staging - #484

Closed
yuechao-qin wants to merge 1 commit into
ycq/staging-integration-gsmfrom
ycq/staging-integration-467
Closed

yuechao-qin wants to merge 1 commit into
ycq/staging-integration-gsmfrom
ycq/staging-integration-467

Conversation

@yuechao-qin

@yuechao-qin yuechao-qin commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Do not merge. A test branch for oasis staging: it adds #467 (secret env vars only for secrets consumed as values) to the commit oasis staging already pins, so staging can run it before it merges.

What is in it

de0ac79, the commit oasis staging pins today and the head of #482, plus #467's own commit (d6f88f3), cherry-picked rather than merged, so the master commits staging does not run yet stay out.

Base

The base is ycq/staging-integration-gsm, #482's branch, at de0ac79. The diff is therefore only #467: 2 files, +62 / −11.

Checks

Check Result
cherry-pick clean; git patch-id equals #467's (017247fdad0f)
pytest 644 passed, the same as on de0ac79: #467 replaces one test with another. The 22 tests/instrumentation/test_execution_tracing.py failures also fail on de0ac79
New test against de0ac79's code fails as intended
black --check ✅

@yuechao-qin
yuechao-qin requested a review from Ark-kun as a code owner November 20, 2026 20:36
@yuechao-qin
yuechao-qin deleted the ycq/staging-integration-467 branch November 20, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant